Fix unconditional retrieval loading for non-retrieval settings - #4
Open
Samar-Khalid wants to merge 2 commits into
Open
Fix unconditional retrieval loading for non-retrieval settings#4Samar-Khalid wants to merge 2 commits into
Samar-Khalid wants to merge 2 commits into
Conversation
added 2 commits
July 30, 2026 05:17
Setting 1 (option=2) and Setting 2 (option=3) do not require table retrieval files, but get_retrieved_tables() was called unconditionally, causing an AssertionError when retrieval files were absent. This fix moves the get_retrieved_tables() call inside the preprocessing_option == 1 guard, so it is only invoked when retrieval is actually needed (Setting 0). Added test verifying that preprocessing_option 2 and 3 succeed without retrieval files.
- Same fix as the ReFoRCE converter: moved get_retrieved_tables() inside the option == 1 guard for DIN-SQL and DAIL-SQL. - Updated regression test to cover all three pipelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where retrieval tables were loaded unconditionally, even for preprocessing settings that use gold tables.
Problem
For preprocessing options that do not require retrieval, the pipeline still called
get_retrieved_tables(), causing unnecessary assertions and failures when retrieval files were unavailable.Root Cause
get_retrieved_tables()was executed before checkingpreprocessing_option, causing retrieval-related logic to run for non-retrieval settings.Changes
Testing
Added regression tests covering:
The existing retrieval behavior remains unchanged for retrieval-based settings.
All tests passed successfully.